Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added feature Tag #888

Merged
merged 3 commits into from
Nov 27, 2023
Merged

fix: added feature Tag #888

merged 3 commits into from
Nov 27, 2023

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Nov 27, 2023

No description provided.

Copy link

In packages/restapi/src/lib/chat/addAdmins.ts:

  • Line 44: Missing closing curly brace after the throw new Error statement.
  • Line 47: upsertPayload object is missing a closing curly brace.
  • Line 48: groupMemberUpdateOptions object is missing a closing curly brace.

In packages/restapi/src/lib/chat/addMembers.ts:

  • Line 46: Missing closing curly brace after the throw new Error statement.
  • Line 49: upsertPayload object is missing a closing curly brace.
  • Line 50: groupMemberUpdateOptions object is missing a closing curly brace.

In packages/restapi/src/lib/chat/approveRequest.ts:

  • Line 33: : is missing after status property in the ApproveRequestOptionsType interface.
  • Line 35: senderAddress property in the ApproveRequestOptionsType interface is not properly commented.
  • Lines 39-40: /* and */ are misplaced and commented out unnecessarily.
  • Line 54: : is missing after status property in the ApproveRequestOptionsType interface.
  • Line 55: sigType property in the ApproveRequestOptionsType interface is commented unnecessarily.
  • Line 77: Missing closing curly brace after the throw new Error statement.
  • Lines 92-93: encryptedSecret property is not defined inside the if condition.
  • Line 102: Missing closing curly brace after the if statement.
  • Line 103: Missing closing parentheses after pgpHelper.pgpEncrypt method.
  • Lines 113-134: Some closing braces are missing or misplaced in the switch statement and the subsequent if statements.

In packages/restapi/src/lib/chat/createGroupV2.ts:

  • Line 86: convertedAdminsPromise and convertedMembersPromise are not awaited inside their respective map functions.
  • Line 99: members and admins arrays are not properly commented.

In packages/restapi/src/lib/chat/modifyRole.ts:

  • Line 41: Missing closing curly brace after the throw new Error statement.
  • Line 44: upsertPayload object is missing a closing curly brace.
  • Line 48: groupMemberUpdateOptions object is missing a closing curly brace.

In packages/restapi/src/lib/chat/removeAdmins.ts:

  • Line 46: Missing closing curly brace after the throw new Error statement.
  • Line 49: groupMemberUpdateOptions object is missing a closing curly brace.

In packages/restapi/src/lib/chat/removeMembers.ts:

  • Line 45: Missing closing curly brace after the throw new Error statement.
  • Line 48: groupMemberUpdateOptions object is missing a closing curly brace.

Please fix these issues and rerun the code.

Copy link

All looks good.

Copy link

In the file packages/restapi/src/lib/chat/addAdmins.ts:

  • Line 45: There is a missing closing bracket } after the error message 'Admin address array cannot be empty!'.

In the file packages/restapi/src/lib/chat/addMembers.ts:

  • Line 43: There is a missing closing bracket } after the error message 'Member address array cannot be empty!'.

In the file packages/restapi/src/lib/chat/approveRequest.ts:

  • Line 30: There is a missing closing bracket } after the property pgpPrivateKey.

In the file packages/restapi/src/lib/chat/createGroupV2.ts:

  • Line 67: There is a missing closing bracket } after the property account.

In the file packages/restapi/src/lib/chat/modifyRole.ts:

  • Line 43: There is a missing closing bracket } after the error message 'Members array cannot be empty!'.

In the file packages/restapi/src/lib/chat/removeAdmins.ts:

  • Line 46: There is a missing closing bracket } after the error message 'Admin address array cannot be empty!'.

Overall, the code logic and syntax seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - Extend initialize function to include feature flags for alpha / breaking changes
2 participants